Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the backslash operator #36394

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

jhpalmieri
Copy link
Member

@jhpalmieri jhpalmieri commented Oct 4, 2023

Deprecate the backslash operator.

Deprecate the backslash operator: it is underused and its current implementation conflicts with standard Python usage of \. A poll on sage-devel supports this decision.

The backslash operator is only used in a few places, mainly matrices and matroids; those uses are deprecated.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@jhpalmieri jhpalmieri force-pushed the deprecate-backslash-operator branch 2 times, most recently from e5f2b90 to d2ad093 Compare October 4, 2023 04:54
@jhpalmieri jhpalmieri marked this pull request as ready for review October 4, 2023 04:58
@jhpalmieri jhpalmieri force-pushed the deprecate-backslash-operator branch from d2ad093 to 686cdd9 Compare October 4, 2023 20:32
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Documentation preview for this PR (built with commit 686cdd9; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 8, 2023

Otherwise, lgtm.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jhpalmieri
Copy link
Member Author

Thank you!

@vbraun vbraun merged commit 41cf276 into sagemath:develop Oct 14, 2023
20 of 28 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants